disallow switch case capture discards #25467
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #24789 (by disallowing it)
also fixes another bug that I noticed, which remains allowed but Actually Works now.
Previously Zig allowed you to write something like,
This seems a bit strange because in other cases, such as when capturing the tag in a switch case,
this produces an error.
The only usecase I can think of for the previous behaviour is if you wanted to assert that all union payloads are able to coerce,
This will compile-error with the
|_|
and pass without it.I don't believe this usecase is strong enough to keep the current behaviour; it was never used in the Zig codebase and I cannot find a single usage of this behaviour in the real world, searching through Sourcegraph.
To be clear, this PR does not remove the ability to do,